mindfulminun/qmk
1
0 Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix Mod-Tap combo regression (#20669)

Browse Source 
* Add keyevent for combo keyrecord

* Fix formatting

* Update quantum/process_keycode/process_combo.c

Co-authored-by: Sergey Vlasov <[email protected]>

* Add combo unit-tests and hot-fix process_record_tap_hint

...as this function tries to lookup the combo keys passed in. This will
be refactored in a later pr.

---------

Co-authored-by: Sergey Vlasov <[email protected]>
Co-authored-by: Stefan Kerkmann <[email protected]>
This commit is contained in:
Pete SevanderSergey VlasovStefan Kerkmann
 authored and GitHub committed 2023-05-10 17:59:52 +02:00
1 parent 6f2a1e4e17
commit 8a332e6f01
6 files changed
+97 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

quantum/process_keycode/process_combo.c
+1
View File
@@ -335,6 +335,7 @@ void apply_combo(uint16_t combo_index, combo_t *combo) {
// this in the end executes the combo when the key_buffer is dumped.
record->keycode = combo->keycode;
record->event.type = COMBO_EVENT;
record->event.key = MAKE_KEYPOS(0, 0);
qrecord->combo_index = combo_index;
ACTIVATE_COMBO(combo);